Read only archive ; use for new issues

Bug 1091

Summary: COMM_FAILURE thrown instead of TRANSIENT after a server restart
Product: JacORB Reporter: Amadeu A. Barbosa Jr <amadeu>
Component: ORBAssignee: Mailinglist to track bugs <jacorb-bugs>
Status: NEW ---    
Severity: enhancement    
Priority: P5    
Version: 3.7   
Hardware: PC   
OS: Windows NT   

Description Amadeu A. Barbosa Jr 2016-11-21 07:47:38 CET
In a client, if the server's IOR is provided with two almost identical
profiles that differ only in the host form, for example one containing the
host in the form of an IP address and the other containing the host's
machine name, JacORB will resolve the machine name into its IP address and
then the two profiles become identical.

In this situation, if the server is offline and a call to it is made, the
following occurs (when using DefaultProfileSelector):

   1. The call is attempted using the first profile's address and a
   TRANSIENT is thrown.
   2. Before returning the call to the client application JacORB sees that
   there are more profiles so proceeds to select the next one.
   3. Since both are equal, DefaultProfileSelector returns null, which
   nullifies the effectiveProfile in the ParsedIOR object.
   4. This leads to a COMM_FAILURE in the next call using the same proxy
   object, when I believe it should still be a TRANSIENT. The proxy does not
   recover from this and will forever throw COMM_FAILURE.

The logic to return null if two profiles are equal in
DefaultProfileSelector seems to be there to prevent a loop in the iterator,
I guess. Besides not accounting for the presented problem, I'm not sure it
should return null in any case where there are profiles to try since
ParsedIOR puts any return it gets into effectiveProfile.

Just removing lines 95-100 from fixes the
COMM_FAILURE and passes the entire JacORB test suite (except for JacoTest
which was already failing before), but I'm not sure this is correct or the
right fix. I did this trying to mimic DefaultProfileSelector's behaviour
before the bug was introduced on commit

(reference on list =
Comment 1 Amadeu A. Barbosa Jr 2016-11-21 13:00:03 CET
pull request