996 2014-11-06 12:09:15 +0000 read_fixed() fails with 0 2014-11-19 06:33:10 +0000 1 1 1 Unclassified JacORB ORB 3.5 All All RESOLVED FIXED P5 major --- 1 juergen jacorb-bugs jacorb oldest_to_newest 3212 0 juergen 2014-11-06 12:09:15 +0000 If you send BigDecimal(new BigInteger("0")) over the wire, the receiving JacORB fails with Zero length BigInteger. Problem is at CDRInputStream.java:897 read_fixed_internal() For 0 the CDR representation is 0C so (outBuffer.length() > 0 || c != 0) is false || false and the 0 gets ignored. 47 49 4F 50 01 02 00 01 00 00 00 0D 00 00 00 04 GIOP .... .... .... 00 00 00 00 00 00 00 00 0C .... .... . FINE read GIOP message of size 25 from ClientGIOPConnection to 172.20.6.163:61759 (1010058) java.lang.NumberFormatException: Zero length BigInteger at java.math.BigInteger.<init>(BigInteger.java:276) at java.math.BigInteger.<init>(BigInteger.java:451) at org.jacorb.orb.CDRInputStream.read_fixed(CDRInputStream.java:838) at demo.hello.FixedStructHelper.read(FixedStructHelper.java:41) at demo.hello._GoodDayStub.testFixed(_GoodDayStub.java:102) at demo.hello.Client.main(Client.java:65) To reproduce: struct FixedStruct { fixed<1,0> fnull; }; interface GoodDay { ... FixedStruct testFixed(in FixedStruct fs); }; return with new BigDecimal(new BigInteger("0")) 3217 1 jacorb 2014-11-07 10:34:20 +0000 Fixed with SHA de510ce7b913a3b681a194c4b1c4cbeae0497289 3241 2 juergen 2014-11-18 09:00:30 +0000 The code still fails if called from the deprecated read_fixed() (which is called from stubs generated with -generate_helper deprecated) If called from read_fixed() digits is -1 and the condition of the new code is false. I think the core problem is in if (outBuffer.length() > 0 || c != 0) { outBuffer.append(c); } which is equivalent to if (c == 0) if (outBuffer.length() == 0) skip the character; I do not understand why this code is there. 3242 3 jacorb 2014-11-18 09:10:49 +0000 I think it relates to some changes from PrismTech - there are existing tests e.g. test/regression/src/org/jacorb/test/orb/dynany/DynAnyFixedTest.java Can you provide a patch that fixes your scenario and doesn't break and preexisting tests? 3243 4 juergen 2014-11-18 10:57:29 +0000 It seems to work if you change your fix to if ((digits == 1 || digits == -1) && outBuffer.length() == 0) 3244 5 juergen 2014-11-19 05:15:01 +0000 I propose to add the digits == -1 condition and close the bug. 3245 6 jacorb 2014-11-19 06:33:10 +0000 Done : SHA 163ee981f523a858e6ea1d0efed586c8d52faec4