<?xml version="1.0" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://www.jacorb.org/bugzilla/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.2"
          urlbase="https://www.jacorb.org/bugzilla/"
          
          maintainer="jacorb@goots.org"
>

    <bug>
          <bug_id>978</bug_id>
          
          <creation_ts>2014-02-26 17:38:24 +0000</creation_ts>
          <short_desc>Request for non_existent() call on a dead object to not generate an error level log message</short_desc>
          <delta_ts>2014-03-21 05:37:09 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>JacORB</product>
          <component>ORB</component>
          <version>3.4</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P5</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Richard G. Hash">richard.hash</reporter>
          <assigned_to name="Mailinglist to track bugs">jacorb-bugs</assigned_to>
          <cc>jacorb</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>3114</commentid>
    <comment_count>0</comment_count>
    <who name="Richard G. Hash">richard.hash</who>
    <bug_when>2014-02-26 17:38:24 +0000</bug_when>
    <thetext>Note: entering this to capture email discussion with Nick.

Currently in 3.4 calling non_existent() on a dead object generates an error level log message with a stack trace. Very old versions of JacORB (e.g. 2.3.1) just silently threw the exception and let the caller deal with it).

This is happening in the orb.Delegate, servant_preinvoke(), which throws a OBJECT_NOT_EXIST, but the outer catch{} block is calling
   logger.error(&quot;unexpected exception during servant_preinvoke&quot;, e);
before it re-throws the exception.

Basically we think that a OBJ_NOT_EXISTS on a non_existent should just silently return &apos;false&apos; (without error level logging).

Suggestion from Nick:
########################
So we would have
   public ServantObject servant_preinvoke( org.omg.CORBA.Object self,
               String operation,
               @SuppressWarnings(&quot;rawtypes&quot;) Class expectedType ) and
/**
  * Only called by servant_preinvoke. Special case method used by non_existent to disable logging for object not exist
  */
private ServantObject servant_preinvoke( org.omg.CORBA.Object self,
                String operation,
                @SuppressWarnings(&quot;rawtypes&quot;) Class expectedType,
		boolean logObjectNotExist )

The test case could do something similar to org.jacorb.test.util.JDKLoggerTest where it checks the file contents for the log file. And the actual test could reuse orb.NonExistentLocalTest.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>3119</commentid>
    <comment_count>1</comment_count>
    <who name="Nick Cross">jacorb</who>
    <bug_when>2014-03-21 05:37:09 +0000</bug_when>
    <thetext>Fixed instead by changing the logging level inside preinvoke for simplicity.

SHA f049e37ff187fc908172312e01f48f49b6b67745</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>