960 2013-07-31 17:12:10 +0000 ORB interception mechanism doesn't transfer ServiceContexts properly in local invocations when application interceptors raise exceptions 2013-11-20 09:38:04 +0000 1 1 1 Unclassified JacORB ORB 3.1 All All RESOLVED FIXED P5 major --- 1 amadeu jacorb-bugs jacorb oldest_to_newest 3047 0 422 amadeu 2013-07-31 17:12:10 +0000 Created attachment 422 Sample code that manifest the bug I observed a bug in org.jacorb.orb.Delegate.servant_preinvoke method when both server and client side are the same process using the same ORB. The client interceptors don't have access to reply ServiceContexts in receive_exception interception point as should be (conform to CORBA spec). The problem doesn't occur in remote invocation cenario. I attached a sample code that manifest this bug. The mainclass demo.InterceptorSameORBServerAndClient manifest this bug. Another classes like demo.InterceptorServer and demo.InterceptorClient show that this bug doesn't affect the remote cenario (when the invocation is remote). Probably when the server side use a differente ORB than the client side the problem probably doesn't occur also. Explanation about my test: The demo.ServerRequestInterceptorImpl implements receive_request and put a ServiceContext with 1234 ID in the ServerRequestInfo and raises a NO_PERMISSION exception. After that, the demo.ClientRequestInterceptorImpl implements receive_exception and try to get the reply ServiceContext with 1234 ID to extract some the information that I put there previously but I got a BAD_PARAM exception as showed in the stacktrace: SEVERE: unexpected exception during servant_preinvoke org.omg.CORBA.BAD_PARAM: No ServiceContext with id 1234 at org.jacorb.orb.portableInterceptor.RequestInfoImpl.get_reply_service_context(RequestInfoImpl.java:192) at org.jacorb.orb.portableInterceptor.ClientRequestInfoImpl.get_reply_service_context(ClientRequestInfoImpl.java:394) at demo.ClientRequestInterceptorImpl.receive_exception(ClientRequestInterceptorImpl.java:26) at org.jacorb.orb.portableInterceptor.ClientInterceptorIterator.invoke(ClientInterceptorIterator.java:138) at org.jacorb.orb.portableInterceptor.AbstractInterceptorIterator.iterate(AbstractInterceptorIterator.java:66) at org.jacorb.orb.portableInterceptor.ClientInterceptorIterator.iterate(ClientInterceptorIterator.java:87) at org.jacorb.orb.DefaultClientInterceptorHandler.invokeInterceptors(DefaultClientInterceptorHandler.java:328) at org.jacorb.orb.DefaultClientInterceptorHandler.handle_receive_exception(DefaultClientInterceptorHandler.java:261) at org.jacorb.orb.DefaultClientInterceptorHandler.handle_receive_exception(DefaultClientInterceptorHandler.java:231) at org.jacorb.orb.Delegate.servant_preinvoke(Delegate.java:2755) at org.omg.CORBA.portable.ObjectImpl._servant_preinvoke(ObjectImpl.java:135) at demo._HelloStub.sayHello(_HelloStub.java:73) at demo.InterceptorSameORBServerAndClient.main(InterceptorSameORBServerAndClient.java:33) Exception in thread "main" org.omg.CORBA.BAD_PARAM: No ServiceContext with id 1234 at org.jacorb.orb.portableInterceptor.RequestInfoImpl.get_reply_service_context(RequestInfoImpl.java:192) at org.jacorb.orb.portableInterceptor.ClientRequestInfoImpl.get_reply_service_context(ClientRequestInfoImpl.java:394) at demo.ClientRequestInterceptorImpl.receive_exception(ClientRequestInterceptorImpl.java:26) at org.jacorb.orb.portableInterceptor.ClientInterceptorIterator.invoke(ClientInterceptorIterator.java:138) at org.jacorb.orb.portableInterceptor.AbstractInterceptorIterator.iterate(AbstractInterceptorIterator.java:66) at org.jacorb.orb.portableInterceptor.ClientInterceptorIterator.iterate(ClientInterceptorIterator.java:87) at org.jacorb.orb.DefaultClientInterceptorHandler.invokeInterceptors(DefaultClientInterceptorHandler.java:328) at org.jacorb.orb.DefaultClientInterceptorHandler.handle_receive_exception(DefaultClientInterceptorHandler.java:261) at org.jacorb.orb.DefaultClientInterceptorHandler.handle_receive_exception(DefaultClientInterceptorHandler.java:231) at org.jacorb.orb.Delegate.servant_preinvoke(Delegate.java:2755) at org.omg.CORBA.portable.ObjectImpl._servant_preinvoke(ObjectImpl.java:135) at demo._HelloStub.sayHello(_HelloStub.java:73) at demo.InterceptorSameORBServerAndClient.main(InterceptorSameORBServerAndClient.java:33) I studied the JacORB ORB code and I tried a very simple patch that seems to resolve this issue. I'd like to ask you to analyse it: --- jacorb-3.1-sources-upstream/src/org/jacorb/orb/Delegate.java 2012-08-19 14:26:54.000000000 -0300 +++ jacorb-3.1-sources-bugfix/src/org/jacorb/orb/Delegate.java 2013-07-30 16:05:57.000000000 -0300 @@ -2748,6 +2748,8 @@ public final class Delegate { if (interceptors != null && orb.hasRequestInterceptors()) { + Collection<ServiceContext> ctx = sinfo.getReplyServiceContexts(); + interceptors.getInfo ().setReplyServiceContexts (ctx.toArray (new ServiceContext[ctx.size ()])); try { if (ex instanceof SystemException) This bug was observed in JacORB 3.1 but it happens also in master branch code hosted in github also. In master branch of github the patch is: diff --git a/src/org/jacorb/orb/Delegate.java b/src/org/jacorb/orb/Delegate.java index a4b4166..3c80ffd 100644 --- a/src/org/jacorb/orb/Delegate.java +++ b/src/org/jacorb/orb/Delegate.java @@ -2885,6 +2885,8 @@ public final class Delegate { try { + Collection<ServiceContext> ctx = sinfo.getReplyServiceContexts(); + interceptors.getInfo ().setReplyServiceContexts (ctx.toArray (new ServiceContext[ctx.size ()])); if (ex instanceof SystemException) { interceptors.handle_receive_exception ( (SystemException) ex); 3083 1 jacorb 2013-11-20 09:38:04 +0000 Fixed by 9659de46abb78a899381ff4f439fbfe5fd246584. Thanks for test and patch. 422 2013-07-31 17:12:10 +0000 2013-07-31 17:12:10 +0000 Sample code that manifest the bug interceptors.tgz application/x-gzip 4090 amadeu H4sIAFE6+FEAA+0da3PbuDHtTKdjfW8/o+p9kK8W35LS2NZVcZyrbmLLYzu9m15vNDQJS3QokseH H73x/+if6G/qX+niQYqiSFGKJSU5cxNZIrBYLIBdYLFYSH0nxL6BvdD1A1EYBr7xYu0gSVKn1UL0 vd2m75KisXcCqtpBsiJ3Wp1OW5U7SJJbsqy9QNL6WZmHKAh1H1jRJ7qJo2I8QLu+XkCHNQUl718K /O6Pv3/x2xcvTnQDDS7QD4gDSXuxAy8FXv+FF3n+33Ike5eX5/wjKfEfeH2bQfnNNP0PhjsRdM+z sfBzpPu6E1oOfvGzCL0o77fk6861Yaj7l2P8r3tFeu/ovjG2brG/L6vt3pHSe93U1OPjptbqtZqv pbdSs/X2Teeop7aOX7dfrqF/fuXQT+s/aL+4gTrK9J/oy6z+ax2t/QK1NsDLHDxz/Z8bf2Fo4om7 1jqWnf/bkiq3OxKMf1tS1Gr+3wpU8/+zhjn9J9q/5kVg2fl/qv+tdqtVzf/bgPzxF4ZHtoWd8Bz/ HOEgTCH1J54t3Oi3+gp1QH+0NW2p+R8QYfwVrdWu7P/twOc8/6vx/K9V8/+GIF//16n9pfqvSrKc 1X+YEir93wZ4uvFBH2FEhn2/VrMmnuuHyPVHgjsZCUeD89c9oec87Ofn9E8vj89Pe+8Kst+5hm4P rm6wEc5h9AdnwpFrYiM35wL7t5aBj1yQvfsFhc8Y+8Jb15/o4YkVwF9jPId/Bg/6lY1ToixkZPza /ZhSScZShYHLO903eWno7mvL0W3kRVe2ZSDD1oMALVI9BH2BHTNAqY5FUK+NJ1AmqKHC0uiXGuR6 vnWrhxhdhL7ljJCjT/B+Kpn2KDLYoJB0xtcijhqcVEDf9tIkdqFOspKEYysQSFXokKPtT9MpJmTw ShF6JBX/bQATvG+ZeMrErWuZyMcGhrl/iO8JB5brNOYGEfnWLpD23bsAzXY3Z2dWsqBi9n4IBYUR Doc+9uyHYcCwhjy7ISuqtsv4vnoI8Y8/xQWHph7qtAH0UUgnM3zQHqQTDaKN9h84H4gkxi0X4AXv jXRpXh1w/BCEeCK4USjASDmh7TSgqAB4vm6EQ9anjV2O/0j/GkQNUGNWLRDeTSrn4zbBQUDU/xDV 3zv43gOBwiaCzgeRca/RbPl6zBHtX+TgOxRPAA1OKMXEUiPphmPsrziKy9KmI1lAu5xKAIo29Fzb fhoFnxVbcxNNQPPdh0YJGyk9b8RD7+Mw8p2pVnKle/zUC1EFnwSK9n9/x7btfpy5NwfL7v80pa1q CrH/pHbl/9sSVPu/Zw35+r9O7S/Xf6UtZfVfk+RK/7cBmf0fNxzYvoRtSBJZSHYfNOVs0GPGR6H5 oz9QxMTy4NbImCQSg5Pm7qHvXd82/8Rtyxxbl+LvMjPlsfap++vXBkXrf9+xQku3rX9j/8lzwErr f1sG/ZcVpV3p/1agWv+fNeTr/zq1v9z/226pWf2X5Fal/9uAYv/vjW64/pVAXl6OL3Nw/ppICXFl EOOg0EHcv+z33vX/ebx2FzHNeasbwMy8ezqLALaGh+edtATt+PRo8KZ/+u3w6M35EB56Zxf5eI7h mtR7WVJX7JN+73xw3DunsFyehzjVq6vgc11dtYqY0zeRB2abHuJT6hD6OCJ95xa4MBmJPEMyxWiJ IxvNNmuxnen5eGgBciPFE7LgD7M7H9OOb+6e9jE80M8FhVBGSjmH7tXNvBsXEsGaJWUFHweufcvY Ad6HPr7GPnYMHDTqaQmp5/lqU/23oqNWN6CGgGCx9sW15LlrY3XMcdgilOaROabjh0M0r00CrMVA uAEdsEvPCxCKZR3h+MMh54HUHuc2clROgMZHeA81iHt9F8nJJ2V3vsu5DzPNocAGdUjTGnH1ef2c UcvVneIx8VX7d6FH13ODcJEYo/TRCjk2SMkwxeIjkJmWKQX64RA1Mnm7NHO+d6ko66Y5NKjPOnZh A3eJ/jdIYxeeC9ViQ7JehFbf4+dEyUFHUjE5fcF+YcUXNLu04iI0qDjuFXLiA73S2M3wMiMwM7Pj iuLi45EFO1qKl2pGsLrsbGjrW2T/Jals+J5kBZbYf3JHacfn/2pHVcD+U+Qq/mc7kG//kdEWotCy hTPfhak+tHBQFB0AfwpsO/iTaxwU2BdMX4WzQW8JlAKDbh7xRHeAAT9mpGfqHsh234FlA7aRRZZK RvyJBbLDEUEQwnjWnuiW02Al2WTw409I90dBcrKXavdebWdnJ1M90N3ZmXYx2CmuF8BEQuaDaXID JoKdHZonBDjkGQ+N+lx3HxH2YX6rZwx4yKovTeQC2mHj0HU4NcL3Tg7FBK+UdLnlSqsS6rSqv6A6 z4SWpHeidHDIlH1KDzRprYAJg38FfQafBLqAkgHYY11JVkXo4EEP1ldySp8ITmK7QFMWWW3nrhtC oTqrDIgI4RgPp2LV2BXoSMLq0GCVFRmOUDupjJ3WD0N36NIsyu2P0k+sMHWJooQBKENT8uytnZ0E TZi6WiF9taWidP6/gL4mg00VqueYH7EelMz/itrRUvG/HZj/W3Kr2v9vBZ79/F9KIC5JUnQnPHXD 3qpFv/ddZ3TmwurxULrg5Osbj9966gpEzMlMD+yhbMP2UIpfbuwutUYRxDWsUsuSmVunuN1fslKV kF9+rWLVrbBa8f1ZyXpFu3s9KxZtaumaRbCmh3zx8RwZ3iQ1wVuwupGKAiZKZHlLeEod4OWe79Fx ooRIMR7NRtY4XmSFNZH5BvJWRcY79FzkNKqzxBQUn/9NZyQ2n338DpCs/3xpLL3/15HI+q9ocnX+ tx2ozv+eNZTb/0/V/lL9B21Xs/ovd6r7H1uByv7/3Ox/Wrqy9yt7/5na+5WZvk0osv8XnbFt6v43 if9Rafyv1q7if7YElf3/rCFf/9ep/eXxfyTmP6P/aqc6/90KLBX/V2zib+RqOMM4HQzPjs9P+hcX /cHphq+Pc6P58sHDb11/pYi97J3uJYpktGvJUL8incy/Rr5Ig8uvkReVXuoaOTd5l7hZvjCQJ3Oz nFNd/Yo5s745Q0+6dh7f5Z0bv9JL5/wOOD8D5qFqkBDvosh9bssBazq5zl0PXGgOiVMK4k1M5uY6 5yYr6tlorlw0bu/PJtJL7jwQSqBBbphcNM+NicpXmBWDo+7Glo0Xh9MV3i5H5L4+iRXLv6+f2+o9 6JgoJjKtZWaiadQnDygkI3ftgjQGs7n13VWFJctZkC89U5Y+4jY4vWg+/U6E1cRzKeLsmv4GCLM7 +vmEP8E1+Oe32Zyx/4Qh82J4ejheYx3L7v/I9/90VPr9j6pW3f/cDnwR+7/q+x83BbP6vwntL4// bbXlrP7LSrX/2wocfHM/sRHoUwCmw2FdFqR6YpEd1t9fvm2+rH/TrR0kktGt7UwfYLsApqblGHbE Cnz9tfg1dRDU0QfLMQ/rgW/UEUFlH8WPLw7DNMKhOMIO9sF8NpuBGxELTbRMO5cuowB2V0yB7K6w YVtegIUbMxRsPXJgMnFGwnfnx8Ojwellr396fL6A2K3ux8ROlOH58dlABKKiDrvoMRZh6qIvWXgp KORTk36CBvlPpdlkvGI/RTxOekotgX2t3bC/Td2zgHpb0KbPTfr8dNI35gdZmyFOU5Yib1tXMXnx PVjTgchUVbzEE0+80v0rC/tW08RX0aipaM2byB6LroedqyhoBuaHJpGnpiJI5F/zxsdtEUiKzL3R VAW56frWiOygKSOIiRWvcIq1gEM3Cr0ozMgpxcQBKXYgprTnUyt8BrL2n+e7xB2w1jqWt/+UTktW 6Pd/q5X9tx2o7L9nDbP6vwntL9d/EvM/q/+t6vu/tgTL2n9cMt7gwPAt6mfq1hA6IK6TbkqGDkSa QrJArYk7uXs6GJ4ox0fv+mcXx8OL92dng/PLVySShLqdry0bB/w2q4nurHCMYHFFE/0WO01urDU9 O4IFGuk+Ro4boiDyiLcc8CERaHOTDpZZXiWpnjMciPTpKrJs88LDRpd6f9jzEaDrjtnlfkfWmKyR COs/piYpLYJTLYQSYpYOT4lrApJh5OOAo7On4ipYPqmB4lF6CYUDMWcMnjz+2fU/wCHMv6NgDaKV gLTk739oSruldVSy/itqFf+7HajW/2cNs/ofa/96fwCkTP8lScrqv9SRqt//2AYUjL8wzF2kPB9f r740LLv/Y+OvIUlRlU5l/20Hvoj5v4r/2hQU6P8atX8J/ZfVrP5LLanS/23Any/HEfouspHSQnLr FfxXVPT6/BIpkqzWcsUA9NWDXZtPo2hG2BGYx/PM1sNr158cykK7FhfypqHqQrzJlEvIMgcsJVNW /8SzLd3hyJ+6K79IyOz/LNNefx0r7P80GRAkuSW1q/3fduBzXv+r33/cOMzoP2j/p/z936n+ax2l 2v9tBebGXxjS+1vCGleCFfZ/mqS2yP6/o1b233bgc57/q/3fxmFO/9eu/eX6L0utrP63pCr+aysw cc3IZtd/WGA0/ZbSa93A/It34nj+zG968Ej8/Rr8r3ZeXy5k9n8ezMX3kzXvAVfy/8rE/9/qVL// syX4Itb/av+3KZjR/41of6n+a7KsZfVfa1f6vxWI42QQjLsTHNbHYei9EkUafyOwGGSBRPOeDU5E jUTQ1hnmq/vASrDv7u6EO5XiKWDOiT+cvLuAghO9aTnQb46BybenQIlXAU0m905DGm9UWh0qwmAR QrfaUBpKwn1g1mm4DJgz2P4HczR3KYEDcSaNXBE7GPlu5PXNLrF6DsT4ieTofmiB8RPC40xUUyqd oHFXdlcm9OMHGnVELxRbzqh7o0Ox6WMtiZZ6A5WiJsoJmuJhS/wbdnjMEP0qpml97QNxJiVGone1 40RVkA/ETBpD5KMt0Cgl7mmPb292+xeD5suXrb825STWKB+RBialOU1CrHg1DP+N5WP64wzdwDcO xGxijbNEg7sC/pgkxFFZqeEipwFcApg48KIzQ8jLpAaMSUp8asCDybJDyovFvaUIqqDMDC1HMFzn 2hpFvh7OpCdt7n71S3p8HuNmz6CyA5N5VJ6eRo3Z7vmjiMa2NX+4ct0wCSgXvVdf/RIf2wk2udB9 jj03sEgXP9JAfCYI8RupNC0Yj3GM+1yGQEV4joFpX4i5nQGSwQdwqQElh0hjPQqEiXvjlowk7Epv mmw4lxpFmejBbUrzeb6JPeyY2DESNctmPKSTMxyzbsphNcsu71jgOpG+fIZnmJ4bhxwxJL2cx2sq NdbLMrlNyVg3blmSMC/fU/WFZuXodKFwTHPwPTYikjjb90lyhjtvrAe4G1/7iW/9gJTR9Mwwubod zKbx1IQAjBt5nC0nzhU8EHP4SSUGBeIePwapaFA2P84LXY64LSNo8yKWJ1UryNNBYMBU3vUjML0n 0EHssZYRqIcuqs1LWLJSdCs3QAUVVFBBBRVUUEEFFXzu8H8SUJjqAKAAAA==