904 2011-06-24 20:17:10 +0000 CDRInputStream.read_string should handle 0 string size gracefully 2011-09-12 17:27:31 +0000 1 1 1 Unclassified JacORB ORB 2.3.1 All All RESOLVED FIXED P2 enhancement --- 1 fabiano.ghisla rnc rnc oldest_to_newest 2722 0 fabiano.ghisla 2011-06-24 20:17:10 +0000 Some ORBs incorrectly encode empty strings as having size 0. The pragmatic way to handle this case would be to return an empty string. Instead, read_string() throws a marshal exception whenever the size parameter is less than 1, making it very hard to use JacORB to integrate with a misbehaving server ORBs. 2723 1 387 fabiano.ghisla 2011-06-24 20:20:16 +0000 Created attachment 387 simple (but wrong) fix 2724 2 388 fabiano.ghisla 2011-06-24 20:21:55 +0000 Created attachment 388 trivial fix 2725 3 rnc 2011-06-27 09:12:19 +0000 This patch would unfortunately make JacORB non-compliant with the specification and may well break the unit tests. Which ORBs are non-compliant? An alternative and more compatible design would be to implement a jacorb property that would enable this behaviour. It should be defaulted to off so that JacORB is compliant out-of-the-box. This would also require changes to etc/jacorb_properties.template, the PDF documentation, doc/REL_NOTES, and ideally a unit test should also be added. 2726 4 389 fabiano.ghisla 2011-06-27 23:04:23 +0000 Created attachment 389 sample implementation of jacorb.interop.lax_null_string_encoding property 2727 5 390 fabiano.ghisla 2011-06-27 23:10:15 +0000 Created attachment 390 unit test showing the property at work. 2728 6 fabiano.ghisla 2011-06-27 23:20:21 +0000 According to the vendor documentation, the ORB showing the wrong string encoding behaviour is Visibroker. I've implemented a (hopefully) proper fix following your suggestions. ProgrammerGuide documentation, release notes and jacorb_properties.template updated as per your request. Was unsure how to add the unit test, so I resorted in updating the existing regression testcase (to test the existing default behaviour), as well as creating a new one testing the actual behaviour when the flag is set. 2729 7 rnc 2011-06-28 08:59:51 +0000 Thats great; thanks for your effort; I'll take a look at it. 2742 8 rnc 2011-09-12 17:27:31 +0000 Bugzilla 904/JAC#639 Enable interop null string marshalling. doc/REL_NOTES doc/ProgrammingGuide/ProgrammingGuide.pdf doc/ProgrammingGuide/Configuration/configuration.tex etc/jacorb_properties.template src/org/jacorb/orb/CDRInputStream.java src/org/jacorb/orb/CDROutputStream.java test/regression/src/org/jacorb/test/orb/CDRInputStreamNullStringTest.java test/regression/src/org/jacorb/test/orb/CDRInputStreamTest.java 387 2011-06-24 20:20:16 +0000 2011-06-24 20:22:50 +0000 simple (but wrong) fix patch.txt text/plain 626 fabiano.ghisla SW5kZXg6IENEUklucHV0U3RyZWFtLmphdmEKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9KYWNP UkIvc3JjL29yZy9qYWNvcmIvb3JiL0NEUklucHV0U3RyZWFtLmphdmEsdgpyZXRyaWV2aW5nIHJl dmlzaW9uIDEuMTM0CmRpZmYgLXUgLXIxLjEzNCBDRFJJbnB1dFN0cmVhbS5qYXZhCi0tLSBDRFJJ bnB1dFN0cmVhbS5qYXZhCTEwIE1heSAyMDExIDE1OjQwOjQwIC0wMDAwCTEuMTM0CisrKyBDRFJJ bnB1dFN0cmVhbS5qYXZhCTI0IEp1biAyMDExIDE3OjUyOjQwIC0wMDAwCkBAIC0xMjU2LDYgKzEy NTYsMTIgQEAKICAgICAgICAgICAgIHRocm93IG5ldyBNQVJTSEFMKCJpbnZhbGlkIHN0cmluZyBz aXplOiAiICsgc2l6ZSk7CiAgICAgICAgIH0KIAorICAgICAgICAvLyBTb21lIE9SQnMgd3Jvbmds eSBlbmNvZGUgZW1wdHkgc3RyaW5nIHdpdGggYSBzaXplIDAKKyAgICAgICAgaWYgKHNpemUgPT0g MCkKKyAgICAgICAgeworICAgICAgICAgICAgcmV0dXJuICIiOworICAgICAgICB9CisKICAgICAg ICAgaW50IHN0YXJ0ID0gcG9zICsgNDsKIAogICAgICAgICBpbmRleCArPSAoc2l6ZSArIDQpOwo= 388 2011-06-24 20:21:55 +0000 2011-06-27 23:04:23 +0000 trivial fix patch.txt text/plain 677 fabiano.ghisla SW5kZXg6IENEUklucHV0U3RyZWFtLmphdmEKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9KYWNP UkIvc3JjL29yZy9qYWNvcmIvb3JiL0NEUklucHV0U3RyZWFtLmphdmEsdgpyZXRyaWV2aW5nIHJl dmlzaW9uIDEuMTM0CmRpZmYgLXUgLXIxLjEzNCBDRFJJbnB1dFN0cmVhbS5qYXZhCi0tLSBDRFJJ bnB1dFN0cmVhbS5qYXZhCTEwIE1heSAyMDExIDE1OjQwOjQwIC0wMDAwCTEuMTM0CisrKyBDRFJJ bnB1dFN0cmVhbS5qYXZhCTI0IEp1biAyMDExIDE4OjIxOjE3IC0wMDAwCkBAIC0xMjUxLDYgKzEy NTEsMTIgQEAKICAgICAgICAgLy8gcmVhZCBzaXplICgjYnl0ZXMpCiAgICAgICAgIGludCBzaXpl ID0gX3JlYWQ0aW50KCBsaXR0bGVFbmRpYW4sIGJ1ZmZlciwgcG9zKTsKIAorICAgICAgICAvLyBT b21lIE9SQnMgd3JvbmdseSBlbmNvZGUgZW1wdHkgc3RyaW5nIHdpdGggYSBzaXplIDAKKyAgICAg ICAgaWYgKHNpemUgPT0gMCkKKyAgICAgICAgeworICAgICAgICAgICAgcmV0dXJuICIiOworICAg ICAgICB9CisKICAgICAgICAgaWYgKHNpemUgPCAxKQogICAgICAgICB7CiAgICAgICAgICAgICB0 aHJvdyBuZXcgTUFSU0hBTCgiaW52YWxpZCBzdHJpbmcgc2l6ZTogIiArIHNpemUpOwo= 389 2011-06-27 23:04:23 +0000 2011-06-27 23:04:23 +0000 sample implementation of jacorb.interop.lax_null_string_encoding property jacorb904.patch text/plain 2701 fabiano.ghisla SW5kZXg6IGRvYy9SRUxfTk9URVMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9KYWNPUkIvZG9j L1JFTF9OT1RFUyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4yMDQKZGlmZiAtcjEuMjA0IFJFTF9O T1RFUwoxMjNhMTI0Cj4gICAgICAgICAtIEFkZGVkIGphY29yYi5pbnRlcm9wLmxheF9udWxsX3N0 cmluZ19lbmNvZGluZyB0byBhbGxvdyBoYW5kbGluZyBvZiBzdHJpbmdzIG9mIHNpemUgMApJbmRl eDogZG9jL1Byb2dyYW1taW5nR3VpZGUvQ29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLnRleAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL0phY09SQi9kb2MvUHJvZ3JhbW1pbmdHdWlkZS9Db25m aWd1cmF0aW9uL2NvbmZpZ3VyYXRpb24udGV4LHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjYyCmRp ZmYgLXIxLjYyIGNvbmZpZ3VyYXRpb24udGV4CjcxM2E3MTQsNzE3Cj4gXHZlcmIiamFjb3JiLmlu dGVyb3AubGF4XyIKPiBcdmVyYiJudWxsX3N0cmluZ19lbmNvZGluZyIgJiBBbGxvdyByZWFkaW5n IG9mIDAgc2l6ZSBzdHJpbmdzLiAKPiBUaGlzIGNhbiBiZSB1c2VmdWwgZm9yIE9SQnMgc3VjaCBh cyBWaXNpQnJva2VyLiAmIGJvb2xlYW4gJiBvZmYgXFwKPiBcaGxpbmUKSW5kZXg6IGV0Yy9qYWNv cmJfcHJvcGVydGllcy50ZW1wbGF0ZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL0phY09SQi9l dGMvamFjb3JiX3Byb3BlcnRpZXMudGVtcGxhdGUsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNzgK ZGlmZiAtcjEuNzggamFjb3JiX3Byb3BlcnRpZXMudGVtcGxhdGUKMzgxYTM4MiwzODYKPiAjIFNv bWUgT1JCcyAoZS5nLiBWaXNpYnJva2VyKSBkbyBub3QgY29ycmVjdGx5IGVuY29kZSBlbXB0eSBz dHJpbmdzCj4gIyBzYXZpbmcgb25lIGJ5dGUgb24gdGhlIHBhbG9hZC4KPiAjIFR1cm5zIHRoaXMg b24gaWYgeW91IHJ1biBpbnRvIHN0cmluZ3Mgd2l0aCBzaXplIDAKPiBqYWNvcmIuaW50ZXJvcC5s YXhfbnVsbF9zdHJpbmdfZW5jb2Rpbmc9b2ZmCj4gCkluZGV4OiBzcmMvb3JnL2phY29yYi9vcmIv Q0RSSW5wdXRTdHJlYW0uamF2YQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL0phY09SQi9zcmMv b3JnL2phY29yYi9vcmIvQ0RSSW5wdXRTdHJlYW0uamF2YSx2CnJldHJpZXZpbmcgcmV2aXNpb24g MS4xMzQKZGlmZiAtcjEuMTM0IENEUklucHV0U3RyZWFtLmphdmEKMTAyYTEwMwo+ICAgICBwcml2 YXRlIGJvb2xlYW4gbGF4TnVsbFN0cmluZ0VuY29kaW5nOwoyNzhhMjgwLDI4MQo+ICAgICAgICAg bGF4TnVsbFN0cmluZ0VuY29kaW5nID0KPiAgICAgICAgICAgICBjb25maWd1cmF0aW9uLmdldEF0 dHJpYnV0ZUFzQm9vbGVhbigiamFjb3JiLmludGVyb3AubGF4X251bGxfc3RyaW5nX2VuY29kaW5n IiwgZmFsc2UpOwoxMjU1YTEyNTksMTI2Mwo+ICAgICAgICAgICAgIGlmIChsYXhOdWxsU3RyaW5n RW5jb2RpbmcgJiYgc2l6ZSA9PSAwKQo+ICAgICAgICAgICAgIHsKPiAgICAgICAgICAgICAgICAg Ly8gU29tZSBPUkJzIHdyb25nbHkgZW5jb2RlIGVtcHR5IHN0cmluZyB3aXRoIGEgc2l6ZSAwCj4g ICAgICAgICAgICAgICAgIHJldHVybiAiIjsKPiAgICAgICAgICAgICB9CkluZGV4OiB0ZXN0L3Jl Z3Jlc3Npb24vc3JjL29yZy9qYWNvcmIvdGVzdC9vcmIvQ0RSSW5wdXRTdHJlYW1UZXN0LmphdmEK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9KYWNPUkIvdGVzdC9yZWdyZXNzaW9uL3NyYy9vcmcv amFjb3JiL3Rlc3Qvb3JiL0NEUklucHV0U3RyZWFtVGVzdC5qYXZhLHYKcmV0cmlldmluZyByZXZp c2lvbiAxLjIKZGlmZiAtcjEuMiBDRFJJbnB1dFN0cmVhbVRlc3QuamF2YQoyNGEyNSwyNgo+IGlt cG9ydCBvcmcub21nLkNPUkJBLk1BUlNIQUw7Cj4gCjE3OGExODEsMTk0Cj4gICAgIHB1YmxpYyB2 b2lkIHRlc3RGYWlsT25OdWxsRW5jb2RlZFN0cmluZygpIHRocm93cyBFeGNlcHRpb24KPiAgICAg ewo+ICAgICAgICAgYnl0ZVtdIGNvZGVkVGV4dCA9IHswLDAsMCwwfTsKPiAgICAgICAgIENEUklu cHV0U3RyZWFtIHN0cmVhbSA9IG5ldyBDRFJJbnB1dFN0cmVhbSggb3JiLCBjb2RlZFRleHQgKTsK PiAgICAgICAgIHRyeSB7Cj4gICAgICAgICAgICAgc3RyZWFtLnJlYWRfc3RyaW5nKCk7Cj4gICAg ICAgICAgICAgZmFpbCgiTnVsbCBlbmNvZGVkIHN0cmluZyBzaG91bGQgaGF2ZSBmYWlsZWQgd2l0 aCBhbiBleGNlcHRpb24iKTsKPiAgICAgICAgIH0gY2F0Y2ggKE1BUlNIQUwgZSkgewo+ICAgICAg ICAgICAgIGFzc2VydE5vdE51bGwoZS5nZXRNZXNzYWdlKCkpOwo+ICAgICAgICAgICAgIGFzc2Vy dFRydWUoIk5vdCBhIE1BUlNIQUxMIGV4Y2VwdGlvbjogIiArIGUuZ2V0TWVzc2FnZSgpLCBlLmdl dE1lc3NhZ2UoKS5tYXRjaGVzKCJeLippbnZhbGlkIHN0cmluZyBzaXplOiAwLiokIikpOwo+ICAg ICAgICAgfQo+ICAgICB9Cj4gCj4gCg== 390 2011-06-27 23:10:15 +0000 2011-06-27 23:10:38 +0000 unit test showing the property at work. CDRInputStreamNullStringTest.java text/plain 1885 fabiano.ghisla cGFja2FnZSBvcmcuamFjb3JiLnRlc3Qub3JiOwovKgogKiAgICAgICAgSmFjT1JCIC0gYSBmcmVl IEphdmEgT1JCCiAqCiAqICAgQ29weXJpZ2h0IChDKSAyMDAwLTIwMTEgR2VyYWxkIEJyb3NlIC8g VGhlIEphY09SQiBUZWFtLgogKgogKiAgIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5 b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKICogICBtb2RpZnkgaXQgdW5kZXIgdGhlIHRl cm1zIG9mIHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYwogKiAgIExpY2Vuc2UgYXMgcHVi bGlzaGVkIGJ5IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlcgogKiAgIHZlcnNp b24gMiBvZiB0aGUgTGljZW5zZSwgb3IgKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lv bi4KICoKICogICBUaGlzIGxpYnJhcnkgaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBp dCB3aWxsIGJlIHVzZWZ1bCwKICogICBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQg ZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgogKiAgIE1FUkNIQU5UQUJJTElUWSBvciBGSVRO RVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUgR05VCiAqICAgTGlicmFyeSBH ZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCiAqCiAqICAgWW91IHNob3Vs ZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMK ICogICBMaWNlbnNlIGFsb25nIHdpdGggdGhpcyBsaWJyYXJ5OyBpZiBub3QsIHdyaXRlIHRvIHRo ZSBGcmVlCiAqICAgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLiwgNjc1IE1hc3MgQXZlLCBDYW1i cmlkZ2UsIE1BIDAyMTM5LCBVU0EuCiAqCiAqLwppbXBvcnQgb3JnLmphY29yYi5vcmIuQ0RSSW5w dXRTdHJlYW07CmltcG9ydCBvcmcuamFjb3JiLm9yYi5naW9wLkNvZGVTZXQ7CmltcG9ydCBvcmcu amFjb3JiLnRlc3QuY29tbW9uLk9SQlRlc3RDYXNlOwppbXBvcnQganVuaXQuZnJhbWV3b3JrLlRl c3RTdWl0ZTsKCnB1YmxpYyBjbGFzcyBDRFJJbnB1dFN0cmVhbU51bGxTdHJpbmdUZXN0IGV4dGVu ZHMgT1JCVGVzdENhc2UKewoKICAgIHB1YmxpYyBzdGF0aWMgVGVzdFN1aXRlIHN1aXRlKCkKICAg IHsKICAgICAgICByZXR1cm4gbmV3IFRlc3RTdWl0ZSggQ0RSSW5wdXRTdHJlYW1OdWxsU3RyaW5n VGVzdC5jbGFzcyApOwogICAgfQoKICAgIHByb3RlY3RlZCB2b2lkIHBhdGNoT1JCUHJvcGVydGll cyhqYXZhLnV0aWwuUHJvcGVydGllcyBwcm9wZXJ0aWVzKSB7CiAgICAJcHJvcGVydGllcy5wdXQo ImphY29yYi5pbnRlcm9wLmxheF9udWxsX3N0cmluZ19lbmNvZGluZyIsICJvbiIpOwogICAgfTsK ICAgIAogICAgcHVibGljIHZvaWQgdGVzdFplcm9TaXplZE51bGxFbmNvZGVkU3RyaW5nKCkgdGhy b3dzIEV4Y2VwdGlvbgogICAgewogICAgICAgIGJ5dGVbXSBjb2RlZFRleHQgPSB7MCwwLDAsMH07 CiAgICAgICAgQ0RSSW5wdXRTdHJlYW0gc3RyZWFtID0gbmV3IENEUklucHV0U3RyZWFtKCBvcmIs IGNvZGVkVGV4dCApOwogICAgICAgIGFzc2VydEVxdWFscyggInJlYWRfc3RyaW5nIG9mIHNpemUg MCIsICIiLCBzdHJlYW0ucmVhZF9zdHJpbmcoKSApOwogICAgfQoKICAgIHB1YmxpYyB2b2lkIHRl c3RDb3JyZWN0bHlFbmNvZGVkRW1wdHlTdHJpbmcoKSB7CiAgICAgICAgYnl0ZVtdIGNvZGVkVGV4 dCA9IHswLDAsMCwxLDB9OwogICAgICAgIENEUklucHV0U3RyZWFtIHN0cmVhbSA9IG5ldyBDRFJJ bnB1dFN0cmVhbSggb3JiLCBjb2RlZFRleHQgKTsKICAgICAgICBhc3NlcnRFcXVhbHMoICJyZWFk X3N0cmluZyBvZiBzaXplIDEiLCAiIiwgc3RyZWFtLnJlYWRfc3RyaW5nKCkgKTsKICAgIH0KICAg IAp9Cg==