1021 2015-09-04 15:27:56 +0000 Incomplete handling of jacorb.interop.indirection_encoding_disable property 2016-01-28 03:16:45 +0000 1 1 1 Unclassified JacORB ORB 3.6.1 PC All NEW P5 normal --- 1 amadeu jacorb-bugs jacorb oldest_to_newest 3350 0 470 amadeu 2015-09-04 15:27:56 +0000 Created attachment 470 Patch to workaround the problem disabling indirection tag on CDROutputStream TAO 6.3.0 is still not working properly with indirection tags on CDR unmarshaling. I was working on an interop test between TAO and JacORB and the property jacorb.interop.indirection_encoding_disable isn't working as argued to. When I setted up jacorb.interop.indirection_encoding_disable=on the CDR output still uses indirection flag (0xffffffff) and proper offsets about last position of that typecode on stream. I found (in the JacORB master github code) some points missing CDROutputStream.isIndirectionEnabled test before writing 0xffffffff on the stream. I attached a diff below to demonstrate where it is missing and another simple refactoring in ComplexTypeCodeWriter. I don't know the code, so it's just a guess. It worked for me but sorry, it isn't an good solution for the problem. 3354 1 amadeu 2015-10-09 15:16:18 +0000 (In reply to Amadeu A. Barbosa Jr from comment #0) > Created attachment 470 [details] > Patch to workaround the problem disabling indirection tag on CDROutputStream > I attached a diff below to demonstrate where it is missing and another > simple refactoring in ComplexTypeCodeWriter. I don't know the code, so it's > just a guess. It worked for me but sorry, it isn't an good solution for the > problem. I was wrong in that refactoring, I've miss understood some portion of ComplexTypeCodeWriter code. Sorry for my mistake. I'll attach an updated diff with the missing checks about indirection tag only. 3355 2 471 amadeu 2015-10-09 15:24:55 +0000 Created attachment 471 Including missing test of the disabling indirection property 3369 3 jacorb 2016-01-28 03:16:45 +0000 Do you have any test cases for this? (ideally pure java) Can you add a pull request at https://github.com/JacORB/JacORB/ ? 470 2015-09-04 15:27:56 +0000 2015-10-09 15:16:54 +0000 Patch to workaround the problem disabling indirection tag on CDROutputStream typecodewriter-and-cdroutput.diff text/plain 4615 amadeu ZGlmZiAtLWdpdCBhL2NvcmUvc3JjL21haW4vamF2YS9vcmcvamFjb3JiL29yYi9DRFJPdXRwdXRT dHJlYW0uamF2YSBiL2NvcmUvc3JjL21haW4vamF2YS9vcmcvamFjb3JiL29yYi9DRFJPdXRwdXRT dHJlYW0uamF2YQppbmRleCA3ZjQ3Y2I4Li40ZDhmY2I5IDEwMDY0NAotLS0gYS9jb3JlL3NyYy9t YWluL2phdmEvb3JnL2phY29yYi9vcmIvQ0RST3V0cHV0U3RyZWFtLmphdmEKKysrIGIvY29yZS9z cmMvbWFpbi9qYXZhL29yZy9qYWNvcmIvb3JiL0NEUk91dHB1dFN0cmVhbS5qYXZhCkBAIC0xODc1 LDcgKzE4NzUsNyBAQCBwdWJsaWMgY2xhc3MgQ0RST3V0cHV0U3RyZWFtCiAgICAgICAgIH0KIAog ICAgICAgICBJbnRlZ2VyIGluZGV4ID0gZ2V0VmFsdWVNYXAoKS5nZXQgKHZhbHVlKTsKLSAgICAg ICAgaWYgKGluZGV4ICE9IG51bGwpCisgICAgICAgIGlmIChpbmRleCAhPSBudWxsICYmIGlzSW5k aXJlY3Rpb25FbmFibGVkKCkpCiAgICAgICAgIHsKICAgICAgICAgICAgIC8vIHZhbHVlIGhhcyBh bHJlYWR5IGJlZW4gd3JpdHRlbiAtLSBtYWtlIGFuIGluZGlyZWN0aW9uCiAgICAgICAgICAgICB3 cml0ZV9sb25nICgweGZmZmZmZmZmKTsKQEAgLTE4OTEsNyArMTg5MSw3IEBAIHB1YmxpYyBjbGFz cyBDRFJPdXRwdXRTdHJlYW0KICAgICBwcml2YXRlIHZvaWQgd3JpdGVfcmVwb3NpdG9yeV9pZChm aW5hbCBTdHJpbmcgcmVwb3NpdG9yeV9pZCkKICAgICB7CiAgICAgICAgIEludGVnZXIgX2luZGV4 ID0gZ2V0UmVwSWRNYXAoKS5nZXQgKHJlcG9zaXRvcnlfaWQpOwotICAgICAgICBpZiAoIF9pbmRl eCA9PSBudWxsKQorICAgICAgICBpZiAoIF9pbmRleCA9PSBudWxsIHx8ICFpc0luZGlyZWN0aW9u RW5hYmxlZCgpICkKICAgICAgICAgewogICAgICAgICAgICAgLy8gYSBuZXcgcmVwb3NpdG9yeSBp ZCAtLSB3cml0ZSBpdAogCkBAIC0xOTI5LDcgKzE5MjksNyBAQCBwdWJsaWMgY2xhc3MgQ0RST3V0 cHV0U3RyZWFtCiAgICAgICAgIHsKICAgICAgICAgICAgIF9pbmRleCA9IGdldENvZGViYXNlTWFw KCkuZ2V0IChjb2RlYmFzZSk7CiAgICAgICAgIH0KLSAgICAgICAgaWYgKCBfaW5kZXggPT0gbnVs bCkKKyAgICAgICAgaWYgKCBfaW5kZXggPT0gbnVsbCAmJiAhaXNJbmRpcmVjdGlvbkVuYWJsZWQo KSkKICAgICAgICAgewogICAgICAgICAgICAgLy8gYSBuZXcgY29kZWJhc2UgLS0gd3JpdGUgaXQj CiAKQEAgLTIxODAsNyArMjE4MCw3IEBAIHB1YmxpYyBjbGFzcyBDRFJPdXRwdXRTdHJlYW0KICAg ICAgICAgICAgICAgICAgICAgewogICAgICAgICAgICAgICAgICAgICAgICAgLy8gbG9vayBhdCB0 aGUgbmV3IHZhbHVlCiAgICAgICAgICAgICAgICAgICAgICAgICBJbnRlZ2VyIGluZGV4ID0gZ2V0 VmFsdWVNYXAoKS5nZXQobmV3VmFsdWUpOwotICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGlu ZGV4ICE9IG51bGwpCisgICAgICAgICAgICAgICAgICAgICAgICBpZiAoaW5kZXggIT0gbnVsbCAm JiBpc0luZGlyZWN0aW9uRW5hYmxlZCgpKQogICAgICAgICAgICAgICAgICAgICAgICAgewogICAg ICAgICAgICAgICAgICAgICAgICAgICAgIC8vIHByZXZpb3VzbHkgbWFyc2hhbGVkIHZhbHVlIC0t IG1ha2UgYW4gaW5kaXJlY3Rpb24KICAgICAgICAgICAgICAgICAgICAgICAgICAgICB3cml0ZV9s b25nICgweGZmZmZmZmZmKTsKZGlmZiAtLWdpdCBhL2NvcmUvc3JjL21haW4vamF2YS9vcmcvamFj b3JiL29yYi90eXBlY29kZS9Db21wbGV4VHlwZUNvZGVXcml0ZXIuamF2YSBiL2NvcmUvc3JjL21h aW4vamF2YS9vcmcvamFjb3JiL29yYi90eXBlY29kZS9Db21wbGV4VHlwZUNvZGVXcml0ZXIuamF2 YQppbmRleCBhMzQzOGFiLi43MmQxNjdjIDEwMDY0NAotLS0gYS9jb3JlL3NyYy9tYWluL2phdmEv b3JnL2phY29yYi9vcmIvdHlwZWNvZGUvQ29tcGxleFR5cGVDb2RlV3JpdGVyLmphdmEKKysrIGIv Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9qYWNvcmIvb3JiL3R5cGVjb2RlL0NvbXBsZXhUeXBlQ29k ZVdyaXRlci5qYXZhCkBAIC0zNCwyNiArMzQsMTkgQEAgcHVibGljIGFic3RyYWN0IGNsYXNzIENv bXBsZXhUeXBlQ29kZVdyaXRlciBpbXBsZW1lbnRzIFR5cGVDb2RlV3JpdGVyCiAgICAgcHVibGlj IHZvaWQgd3JpdGVUeXBlQ29kZShUeXBlQ29kZSB0eXBlQ29kZSwgQ0RST3V0cHV0U3RyZWFtIG91 dCwKICAgICAgICAgICAgIE1hcCByZWN1cnNpdmVUQ01hcCwgTWFwIHJlcGVhdGVkVENNYXApCiAg ICAgewotICAgICAgICBpZiAob3V0LmlzSW5kaXJlY3Rpb25FbmFibGVkKCkgJiYgcmVwZWF0ZWRU Q01hcC5jb250YWluc0tleSh0eXBlQ29kZSkpCisgICAgICAgIHRyeQogICAgICAgICB7Ci0gICAg ICAgICAgICB3cml0ZUluZGlyZWN0aW9uTWFya2VyKG91dCwgdHlwZUNvZGUsIHJlcGVhdGVkVENN YXApOworICAgICAgICAgICAgdHJ5V3JpdGVUeXBlQ29kZSh0eXBlQ29kZSwgb3V0LCByZWN1cnNp dmVUQ01hcCwgcmVwZWF0ZWRUQ01hcCk7CiAgICAgICAgIH0KLSAgICAgICAgZWxzZQorICAgICAg ICBjYXRjaCAoQmFkS2luZCBlKQogICAgICAgICB7Ci0gICAgICAgICAgICB0cnkKLSAgICAgICAg ICAgIHsKLSAgICAgICAgICAgICAgICB0cnlXcml0ZVR5cGVDb2RlKHR5cGVDb2RlLCBvdXQsIHJl Y3Vyc2l2ZVRDTWFwLCByZXBlYXRlZFRDTWFwKTsKLSAgICAgICAgICAgIH0KLSAgICAgICAgICAg IGNhdGNoIChCYWRLaW5kIGUpCi0gICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgYXNzZXJ0 IGZhbHNlOwotICAgICAgICAgICAgICAgIHRocm93IG5ldyBSdW50aW1lRXhjZXB0aW9uKGUpOwot ICAgICAgICAgICAgfQotICAgICAgICAgICAgY2F0Y2ggKEJvdW5kcyBlKQotICAgICAgICAgICAg ewotICAgICAgICAgICAgICAgIGFzc2VydCBmYWxzZTsKLSAgICAgICAgICAgICAgICB0aHJvdyBu ZXcgUnVudGltZUV4Y2VwdGlvbihlKTsKLSAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGFzc2Vy dCBmYWxzZTsKKyAgICAgICAgICAgIHRocm93IG5ldyBSdW50aW1lRXhjZXB0aW9uKGUpOworICAg ICAgICB9CisgICAgICAgIGNhdGNoIChCb3VuZHMgZSkKKyAgICAgICAgeworICAgICAgICAgICAg YXNzZXJ0IGZhbHNlOworICAgICAgICAgICAgdGhyb3cgbmV3IFJ1bnRpbWVFeGNlcHRpb24oZSk7 CiAgICAgICAgIH0KICAgICB9CiAKQEAgLTgyLDE1ICs3NSw0IEBAIHB1YmxpYyBhYnN0cmFjdCBj bGFzcyBDb21wbGV4VHlwZUNvZGVXcml0ZXIgaW1wbGVtZW50cyBUeXBlQ29kZVdyaXRlcgogICAg IH0KIAogICAgIHByb3RlY3RlZCBhYnN0cmFjdCB2b2lkIGRvV3JpdGVUeXBlQ29kZVBhcmFtZXRl cnMoVHlwZUNvZGUgdHlwZUNvZGUsIENEUk91dHB1dFN0cmVhbSBvdXQsIE1hcCByZWN1cnNpdmVU Q01hcCwgTWFwIHJlcGVhdGVkVENNYXApIHRocm93cyBCYWRLaW5kLCBCb3VuZHM7Ci0KLSAgICBw cml2YXRlIGZpbmFsIHZvaWQgd3JpdGVJbmRpcmVjdGlvbk1hcmtlcihmaW5hbCBDRFJPdXRwdXRT dHJlYW0gb3V0LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGZpbmFsIE9iamVjdCBrZXksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgZmluYWwgTWFwIGluZGlyZWN0aW9uVENNYXApCi0gICAgewotICAgICAgICBvdXQu d3JpdGVfbG9uZyggLTEgKTsgLy8gcmVjdXJzaW9uIG1hcmtlcgotICAgICAgICBpbnQgbmVnYXRp dmVfb2Zmc2V0ID0KLSAgICAgICAgICAgICgoSW50ZWdlcikgaW5kaXJlY3Rpb25UQ01hcC5nZXQo a2V5KSkuaW50VmFsdWUoKSAtIG91dC5nZXRfcG9zKCkgLSA0OwotCi0gICAgICAgIG91dC53cml0 ZV9sb25nKCBuZWdhdGl2ZV9vZmZzZXQgKTsKLSAgICB9CiB9CmRpZmYgLS1naXQgYS9jb3JlL3Ny Yy9tYWluL2phdmEvb3JnL2phY29yYi9vcmIvdHlwZWNvZGUvRGVsZWdhdGluZ1R5cGVDb2RlV3Jp dGVyLmphdmEgYi9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2phY29yYi9vcmIvdHlwZWNvZGUvRGVs ZWdhdGluZ1R5cGVDb2RlV3JpdGVyLmphdmEKaW5kZXggMjAzMDhhNi4uYzM5MDgzMSAxMDA2NDQK LS0tIGEvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9qYWNvcmIvb3JiL3R5cGVjb2RlL0RlbGVnYXRp bmdUeXBlQ29kZVdyaXRlci5qYXZhCisrKyBiL2NvcmUvc3JjL21haW4vamF2YS9vcmcvamFjb3Ji L29yYi90eXBlY29kZS9EZWxlZ2F0aW5nVHlwZUNvZGVXcml0ZXIuamF2YQpAQCAtNjgsNyArNjgs NyBAQCBwdWJsaWMgY2xhc3MgRGVsZWdhdGluZ1R5cGVDb2RlV3JpdGVyCiAgICAgewogICAgICAg ICB0cnkKICAgICAgICAgewotICAgICAgICAgICAgaWYoVHlwZUNvZGUuaXNSZWN1cnNpdmUodHlw ZUNvZGUpICYmIHJlY3Vyc2l2ZVRDTWFwLmNvbnRhaW5zS2V5KHR5cGVDb2RlLmlkKCkpKQorICAg ICAgICAgICAgaWYob3V0LmlzSW5kaXJlY3Rpb25FbmFibGVkKCkgJiYgVHlwZUNvZGUuaXNSZWN1 cnNpdmUodHlwZUNvZGUpICYmIHJlY3Vyc2l2ZVRDTWFwLmNvbnRhaW5zS2V5KHR5cGVDb2RlLmlk KCkpKQogICAgICAgICAgICAgewogICAgICAgICAgICAgICAgIHdyaXRlSW5kaXJlY3Rpb25NYXJr ZXIob3V0LCB0eXBlQ29kZS5pZCgpLCByZWN1cnNpdmVUQ01hcCk7CiAgICAgICAgICAgICB9Cg== 471 2015-10-09 15:24:55 +0000 2015-10-09 15:24:55 +0000 Including missing test of the disabling indirection property typecodewriter-and-cdroutput.diff text/plain 2430 amadeu ZGlmZiAtLWdpdCBhL2NvcmUvc3JjL21haW4vamF2YS9vcmcvamFjb3JiL29yYi9DRFJPdXRwdXRT dHJlYW0uamF2YSBiL2NvcmUvc3JjL21haW4vamF2YS9vcmcvamFjb3JiL29yYi9DRFJPdXRwdXRT dHJlYW0uamF2YQppbmRleCA3ZjQ3Y2I4Li40ZDhmY2I5IDEwMDY0NAotLS0gYS9jb3JlL3NyYy9t YWluL2phdmEvb3JnL2phY29yYi9vcmIvQ0RST3V0cHV0U3RyZWFtLmphdmEKKysrIGIvY29yZS9z cmMvbWFpbi9qYXZhL29yZy9qYWNvcmIvb3JiL0NEUk91dHB1dFN0cmVhbS5qYXZhCkBAIC0xODc1 LDcgKzE4NzUsNyBAQCBwdWJsaWMgY2xhc3MgQ0RST3V0cHV0U3RyZWFtCiAgICAgICAgIH0KIAog ICAgICAgICBJbnRlZ2VyIGluZGV4ID0gZ2V0VmFsdWVNYXAoKS5nZXQgKHZhbHVlKTsKLSAgICAg ICAgaWYgKGluZGV4ICE9IG51bGwpCisgICAgICAgIGlmIChpbmRleCAhPSBudWxsICYmIGlzSW5k aXJlY3Rpb25FbmFibGVkKCkpCiAgICAgICAgIHsKICAgICAgICAgICAgIC8vIHZhbHVlIGhhcyBh bHJlYWR5IGJlZW4gd3JpdHRlbiAtLSBtYWtlIGFuIGluZGlyZWN0aW9uCiAgICAgICAgICAgICB3 cml0ZV9sb25nICgweGZmZmZmZmZmKTsKQEAgLTE4OTEsNyArMTg5MSw3IEBAIHB1YmxpYyBjbGFz cyBDRFJPdXRwdXRTdHJlYW0KICAgICBwcml2YXRlIHZvaWQgd3JpdGVfcmVwb3NpdG9yeV9pZChm aW5hbCBTdHJpbmcgcmVwb3NpdG9yeV9pZCkKICAgICB7CiAgICAgICAgIEludGVnZXIgX2luZGV4 ID0gZ2V0UmVwSWRNYXAoKS5nZXQgKHJlcG9zaXRvcnlfaWQpOwotICAgICAgICBpZiAoIF9pbmRl eCA9PSBudWxsKQorICAgICAgICBpZiAoIF9pbmRleCA9PSBudWxsIHx8ICFpc0luZGlyZWN0aW9u RW5hYmxlZCgpICkKICAgICAgICAgewogICAgICAgICAgICAgLy8gYSBuZXcgcmVwb3NpdG9yeSBp ZCAtLSB3cml0ZSBpdAogCkBAIC0xOTI5LDcgKzE5MjksNyBAQCBwdWJsaWMgY2xhc3MgQ0RST3V0 cHV0U3RyZWFtCiAgICAgICAgIHsKICAgICAgICAgICAgIF9pbmRleCA9IGdldENvZGViYXNlTWFw KCkuZ2V0IChjb2RlYmFzZSk7CiAgICAgICAgIH0KLSAgICAgICAgaWYgKCBfaW5kZXggPT0gbnVs bCkKKyAgICAgICAgaWYgKCBfaW5kZXggPT0gbnVsbCAmJiAhaXNJbmRpcmVjdGlvbkVuYWJsZWQo KSkKICAgICAgICAgewogICAgICAgICAgICAgLy8gYSBuZXcgY29kZWJhc2UgLS0gd3JpdGUgaXQj CiAKQEAgLTIxODAsNyArMjE4MCw3IEBAIHB1YmxpYyBjbGFzcyBDRFJPdXRwdXRTdHJlYW0KICAg ICAgICAgICAgICAgICAgICAgewogICAgICAgICAgICAgICAgICAgICAgICAgLy8gbG9vayBhdCB0 aGUgbmV3IHZhbHVlCiAgICAgICAgICAgICAgICAgICAgICAgICBJbnRlZ2VyIGluZGV4ID0gZ2V0 VmFsdWVNYXAoKS5nZXQobmV3VmFsdWUpOwotICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGlu ZGV4ICE9IG51bGwpCisgICAgICAgICAgICAgICAgICAgICAgICBpZiAoaW5kZXggIT0gbnVsbCAm JiBpc0luZGlyZWN0aW9uRW5hYmxlZCgpKQogICAgICAgICAgICAgICAgICAgICAgICAgewogICAg ICAgICAgICAgICAgICAgICAgICAgICAgIC8vIHByZXZpb3VzbHkgbWFyc2hhbGVkIHZhbHVlIC0t IG1ha2UgYW4gaW5kaXJlY3Rpb24KICAgICAgICAgICAgICAgICAgICAgICAgICAgICB3cml0ZV9s b25nICgweGZmZmZmZmZmKTsKZGlmZiAtLWdpdCBhL2NvcmUvc3JjL21haW4vamF2YS9vcmcvamFj b3JiL29yYi90eXBlY29kZS9EZWxlZ2F0aW5nVHlwZUNvZGVXcml0ZXIuamF2YSBiL2NvcmUvc3Jj L21haW4vamF2YS9vcmcvamFjb3JiL29yYi90eXBlY29kZS9EZWxlZ2F0aW5nVHlwZUNvZGVXcml0 ZXIuamF2YQppbmRleCAyMDMwOGE2Li5jMzkwODMxIDEwMDY0NAotLS0gYS9jb3JlL3NyYy9tYWlu L2phdmEvb3JnL2phY29yYi9vcmIvdHlwZWNvZGUvRGVsZWdhdGluZ1R5cGVDb2RlV3JpdGVyLmph dmEKKysrIGIvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9qYWNvcmIvb3JiL3R5cGVjb2RlL0RlbGVn YXRpbmdUeXBlQ29kZVdyaXRlci5qYXZhCkBAIC02OCw3ICs2OCw3IEBAIHB1YmxpYyBjbGFzcyBE ZWxlZ2F0aW5nVHlwZUNvZGVXcml0ZXIKICAgICB7CiAgICAgICAgIHRyeQogICAgICAgICB7Ci0g ICAgICAgICAgICBpZihUeXBlQ29kZS5pc1JlY3Vyc2l2ZSh0eXBlQ29kZSkgJiYgcmVjdXJzaXZl VENNYXAuY29udGFpbnNLZXkodHlwZUNvZGUuaWQoKSkpCisgICAgICAgICAgICBpZihvdXQuaXNJ bmRpcmVjdGlvbkVuYWJsZWQoKSAmJiBUeXBlQ29kZS5pc1JlY3Vyc2l2ZSh0eXBlQ29kZSkgJiYg cmVjdXJzaXZlVENNYXAuY29udGFpbnNLZXkodHlwZUNvZGUuaWQoKSkpCiAgICAgICAgICAgICB7 CiAgICAgICAgICAgICAgICAgd3JpdGVJbmRpcmVjdGlvbk1hcmtlcihvdXQsIHR5cGVDb2RlLmlk KCksIHJlY3Vyc2l2ZVRDTWFwKTsKICAgICAgICAgICAgIH0K